Skip to content

Fix filename parsing for multiple dots#340

Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom
avinxshKD:fix/multi-dot-filename-parsing
Feb 18, 2026
Merged

Fix filename parsing for multiple dots#340
pradeeban merged 1 commit intoControlCore-Project:devfrom
avinxshKD:fix/multi-dot-filename-parsing

Conversation

@avinxshKD
Copy link
Copy Markdown
Contributor

Changed all sourcecode.split(".") to sourcecode.rsplit(".", 1) in mkconcore.py (22 instances)...Now handles filenames like data.processor.py without breaking on the tuple unpack

Splitting from the right gives us exactly two parts every time, everything before the last dot becomes the name, last part is the extension

Fixes #283

@avinxshKD avinxshKD force-pushed the fix/multi-dot-filename-parsing branch from 9393ce5 to df5bbee Compare February 15, 2026 10:48
@avinxshKD
Copy link
Copy Markdown
Contributor Author

@pradeeban Worked on the fix, nd thanks for confirming the approach
Used rsplit('.', 1) across all 22 instances so filenames with multiple dots parse correctly now happily

@avinxshKD
Copy link
Copy Markdown
Contributor Author

avinxshKD commented Feb 15, 2026

hey @pradeeban, hve been reading through mkconcore.py to understand the workflow generation nd noticed it's handling a lot in one file (parsing graphml, building adjacency matrix, zmq port setup and generating scripts for docker/posix/windows). It's about 1300 lines now and still growing.....

I was thinking it might be easier to maintain if we split it into separate modules. Something like having the graph parser in one file, platform-specific generators in another, and port mapping separate. that way we could test each part independently and add new features without touching everything

I've already been working in there for the multi-dot filename fix, so I have a decent sense of how it flows. If this sounds like a useful direction, so you'd want this tackled now or I could include a proper plan for it in my GSoC proposal and work on it during the summer. Just wanted to check with you first if it aligns with the project's goals or if there's a reason to keep it as one file. Thanks 🌸

@pradeeban
Copy link
Copy Markdown
Member

Hey @avinxshKD, Pls do not bother with refactoring that one-file. That is too much trouble for now.

@pradeeban pradeeban merged commit 2aa2b5c into ControlCore-Project:dev Feb 18, 2026
6 checks passed
@avinxshKD
Copy link
Copy Markdown
Contributor Author

Hey @pradeeban sounds good, will keep it as-is. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants