Skip to content

fix: add missing return in concoredocker.py write() after ZMQ send #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pradeeban merged 1 commit into from
Feb 18, 2026
Merged

fix: add missing return in concoredocker.py write() after ZMQ send #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions concoredocker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,12 +276,20 @@ def write(port_identifier, name, val, delta=0):
if isinstance(port_identifier, str) and port_identifier in zmq_ports:
zmq_p = zmq_ports[port_identifier]
try:
zmq_p.send_json_with_retry(val)
zmq_val = convert_numpy_to_python(val)
if isinstance(zmq_val, list):
# Prepend simtime to match file-based write behavior
payload = [simtime + delta] + zmq_val
zmq_p.send_json_with_retry(payload)
simtime += delta
else:
zmq_p.send_json_with_retry(zmq_val)
except zmq.error.ZMQError as e:
logging.error(f"ZMQ write error on port {port_identifier} (name: {name}): {e}")
except Exception as e:
logging.error(f"Unexpected error during ZMQ write on port {port_identifier} (name: {name}): {e}")

return

try:
file_port_num = int(port_identifier)
file_path = os.path.join(outpath, str(file_port_num), name)
Expand Down