fix simtime update in write_FM and write_SM functions#351
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 18, 2026
Merged
fix simtime update in write_FM and write_SM functions#351pradeeban merged 1 commit intoControlCore-Project:devfrom
pradeeban merged 1 commit intoControlCore-Project:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical bug where the C++ write_FM and write_SM functions were writing timestamps into output files but failing to advance the simtime member variable, causing simulations to be stuck at the same time across steps. The fix adds simtime += delta statements immediately after successful writes in both functions, matching the behavior of the Python reference implementation.
Changes:
- Added
simtime += deltatowrite_FMfunction for vector payloads after successful file write - Added
simtime += deltatowrite_SMfunction for vector payloads after successful shared memory write
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While porting behavior from Python to C++, I found that [write_FM] and [write_SM] were writing timestamps into the output but never advancing the [simtime] member. That left simulations stuck at the same time across steps.
This change makes the C++ functions increment [simtime] by [delta] immediately after a successful write (vector payloads only, matching the Python implementation).