fix simtime not advancing in MATLAB write function#353
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 18, 2026
Merged
fix simtime not advancing in MATLAB write function#353pradeeban merged 1 commit intoControlCore-Project:devfrom
pradeeban merged 1 commit intoControlCore-Project:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes MATLAB simulation time progression by updating the global concore.simtime after a successful write, aligning MATLAB behavior with the Python (and C++) implementations so time advances across steps.
Changes:
- Update
concore.simtimebydeltaafter a successfulconcore_writefile write.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MATLAB write function was including [simtime+delta] in the output but never updating the global [concore.simtime] variable, leaving simulations frozen at the initial time step. This adds the missing update after successful writes, matching the Python and recently-fixed C++ implementations.