Fix/zmq simtime framing#383
Merged
pradeeban merged 2 commits intoControlCore-Project:devfrom Feb 18, 2026
Merged
Conversation
Contributor
Author
|
hey @pradeeban should i add a zmq roundtrip test for concoredocker.py? test_concore.py has one but concoredocker doesn't. also lmk if there's other files doing zmq i/o that might need the same fix, happy to |
Member
Sure, go ahead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concoredocker.py zmq read/write now strips/prepends simtime like concore.py does, fixes payload mismatch between docker and non-docker nodes
fixes #382