refactor: eliminate duplicate import_concoredocker.m logic and fix Windows-only batch generation (fixes #285)#397
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 19, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #285 by preventing Windows-only concorekill.bat generation in non-Windows environments, especially for Docker-generated (Linux) builds of the MATLAB/Octave runtime helpers.
Changes:
- Wrapped
concorekill.batgeneration inimport_concore.mwith anispcguard so it only runs on Windows. - Removed
concorekill.batgeneration fromimport_concoredocker.m(Docker/Linux template).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| import_concore.m | Generates concorekill.bat only on Windows via ispc guard; rest of initialization unchanged. |
| import_concoredocker.m | Removes Windows batch generation from the Docker template while keeping the same init logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… generation in Docker, and fix file descriptor leaks (fixes ControlCore-Project#285)
9891ba1 to
4dd4d7d
Compare
Member
|
/gemini-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pradeeban Sir
This PR resolves Issue #285 by removing duplication between import_concore.m and import_concoredocker.m, and addresses Copilot review feedback on file descriptor leaks and error handling.
Changes Made
Behavior
Scope
Testing