feat: create and store AppDidKey on localStorage and Update the response to return read/write zCaps #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
0marSalah
force-pushed
the
394-create-app-did-key-on-app-load
branch
from
10a5e02 to
88c4b15
Compare
0marSalah
changed the title
0marSalah
changed the title
app/components/ClientWrapper.tsx
Outdated
| import { ReactNode, useEffect } from 'react' | ||
| import { getOrCreateAppInstanceDid } from '@cooperation/vc-storage' | ||
|
|
||
| export function ClientWrapper({ children }: { children: ReactNode }) { |
Collaborator
There was a problem hiding this comment.
I don't think this wrapper style is the right move. It should likely be a component lifecycle hook on ClientLayout, instead of a separate wrapper component.
Member
Author
There was a problem hiding this comment.
Good point — makes sense to move this into a useEffect inside ClientLayout to keep things co-located. I’ll refactor accordingly. Thanks.
0marSalah
commented
Jul 30, 2025
| : '#F0F4F8' | ||
| }} | ||
| > | ||
| <AppDidInitializer /> |
Member
Author
There was a problem hiding this comment.
@dmitrizagidulin - I added <AppDidInitializer /> because putting the getOrCreateAppInstanceDid() logic directly in ClientLayout runs it only after the user is authenticated. This way, the App DID is initialized earlier, before any auth checks, without using a wrapper.
0marSalah
force-pushed
the
394-create-app-did-key-on-app-load
branch
from
83c2446 to
7201ed4
Compare
…c-strage utility function getOrCreateAppInstanceDid
… vprQuery function appInstanceDid
…and enhance logging for appInstanceDid
0marSalah
force-pushed
the
394-create-app-did-key-on-app-load
branch
from
34d45a5 to
ceb1827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on: Cooperation-org/vc-storage#51
Related Issue:
-1: #394
-2: #395