feat: add Kimi Code CLI client configurator#1119
Open
namquang93 wants to merge 1 commit into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR introduces Kimi Code as a supported MCP client by adding a new configurator class that extends the existing JsonFileMcpConfigurator pattern, accompanying Unity metadata, and documentation updates that introduce Kimi Code across the README's introduction, prerequisites, auto-connection instructions, and release notes. ChangesKimi Code Client Integration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@MCPForUnity/Editor/Clients/Configurators/KimiCodeConfigurator.cs`:
- Around line 32-35: The hardcoded manual-path strings in KimiCodeConfigurator
that reference "~/.kimi/mcp.json" (the messages around "Click 'Auto
Configure'..." and "OR click 'Manual Setup'...") should be made
platform-neutral: update the text to either display the runtime-resolved config
path from the configurator/UI (e.g., use the existing method/property that
returns the resolved config path) or replace the literal with OS-agnostic
wording like "your Kimi config file (path shown above)" or "the config file path
shown in the UI" so Windows users aren’t misled; modify the message constants in
KimiCodeConfigurator accordingly and ensure any displayed resolved path uses the
configurator’s path-resolving function.
In `@README.md`:
- Line 34: The changelog entry for "* **v9.6.9** — Added Kimi Code CLI client
configurator." is out of order relative to the "Recent Updates" top version
v9.6.3; either move the v9.6.9 bullet from the "Older releases" section into
"Recent Updates" (so the chronology is descending) or correct the version number
to the intended release (e.g., change v9.6.9 to v9.6.3) so that the entries for
v9.6.3 and v9.6.9 are consistent across the README; update the single list item
text containing "v9.6.9" accordingly and verify the "Recent Updates" header
ordering mentions "v9.6.3" still reads correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 06d4cf67-eb08-4537-9552-df89d6005d58
📒 Files selected for processing (3)
MCPForUnity/Editor/Clients/Configurators/KimiCodeConfigurator.csMCPForUnity/Editor/Clients/Configurators/KimiCodeConfigurator.cs.metaREADME.md
Comment on lines
+32
to
+35
| "Click 'Auto Configure' to automatically add UnityMCP to ~/.kimi/mcp.json", | ||
| "OR click 'Manual Setup' to copy the configuration JSON", | ||
| "Open ~/.kimi/mcp.json and paste the configuration", | ||
| "Save and restart Kimi Code CLI", |
Contributor
There was a problem hiding this comment.
Use platform-neutral manual-path instructions
Manual setup currently hardcodes ~/.kimi/mcp.json, which is unclear for Windows users. Prefer referencing the resolved config path shown by the configurator/UI or listing OS-specific paths.
Suggested wording update
- "Click 'Auto Configure' to automatically add UnityMCP to ~/.kimi/mcp.json",
+ "Click 'Auto Configure' to automatically add UnityMCP to the Kimi config file",
"OR click 'Manual Setup' to copy the configuration JSON",
- "Open ~/.kimi/mcp.json and paste the configuration",
+ "Open Kimi's MCP config file for your OS and paste the configuration",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "Click 'Auto Configure' to automatically add UnityMCP to ~/.kimi/mcp.json", | |
| "OR click 'Manual Setup' to copy the configuration JSON", | |
| "Open ~/.kimi/mcp.json and paste the configuration", | |
| "Save and restart Kimi Code CLI", | |
| "Click 'Auto Configure' to automatically add UnityMCP to the Kimi config file", | |
| "OR click 'Manual Setup' to copy the configuration JSON", | |
| "Open Kimi's MCP config file for your OS and paste the configuration", | |
| "Save and restart Kimi Code CLI", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@MCPForUnity/Editor/Clients/Configurators/KimiCodeConfigurator.cs` around
lines 32 - 35, The hardcoded manual-path strings in KimiCodeConfigurator that
reference "~/.kimi/mcp.json" (the messages around "Click 'Auto Configure'..."
and "OR click 'Manual Setup'...") should be made platform-neutral: update the
text to either display the runtime-resolved config path from the configurator/UI
(e.g., use the existing method/property that returns the resolved config path)
or replace the literal with OS-agnostic wording like "your Kimi config file
(path shown above)" or "the config file path shown in the UI" so Windows users
aren’t misled; modify the message constants in KimiCodeConfigurator accordingly
and ensure any displayed resolved path uses the configurator’s path-resolving
function.
| <details> | ||
| <summary>Older releases</summary> | ||
|
|
||
| * **v9.6.9** — Added Kimi Code CLI client configurator. |
Contributor
There was a problem hiding this comment.
Fix release chronology in changelog section
Line 34 lists v9.6.9 under “Older releases”, but the “Recent Updates” section tops out at v9.6.3. This version ordering is inconsistent and can confuse users scanning upgrade history.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` at line 34, The changelog entry for "* **v9.6.9** — Added Kimi
Code CLI client configurator." is out of order relative to the "Recent Updates"
top version v9.6.3; either move the v9.6.9 bullet from the "Older releases"
section into "Recent Updates" (so the chronology is descending) or correct the
version number to the intended release (e.g., change v9.6.9 to v9.6.3) so that
the entries for v9.6.3 and v9.6.9 are consistent across the README; update the
single list item text containing "v9.6.9" accordingly and verify the "Recent
Updates" header ordering mentions "v9.6.3" still reads correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for Kimi Code.
Type of Change
Changes Made
MCPForUnity/Editor/Clients/Configurators/KimiCodeConfigurator.csthat configures Kimi Code for Unity MCP.Testing/Screenshots/Recordings
Documentation Updates
tools/UPDATE_DOCS_PROMPT.md(recommended)tools/UPDATE_DOCS.mdRelated Issues
Additional Notes
Summary by CodeRabbit
New Features
Documentation