Skip to content

fix: remove nullable annotation causing CS8632 warning #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Scriptwonder merged 2 commits into from
Mar 23, 2026
Merged

fix: remove nullable annotation causing CS8632 warning #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1be434e
fix: remove nullable annotation to avoid CS8632 warning
Scriptwonder Mar 23, 2026
9f9aa32
fix: remove obsolete PrefabInstanceStatus.Disconnected check (CS0618)
Scriptwonder Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MCPForUnity/Editor/Services/IPackageUpdateService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public interface IPackageUpdateService
/// Returns a cached update result if one exists for today, or null if a network fetch is needed.
/// Main-thread only (reads EditorPrefs).
/// </summary>
UpdateCheckResult? TryGetCachedResult(string currentVersion);
UpdateCheckResult TryGetCachedResult(string currentVersion);

/// <summary>
/// Performs only the network fetch and version comparison (no EditorPrefs access).
Expand Down
2 changes: 1 addition & 1 deletion MCPForUnity/Editor/Services/PackageUpdateService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public UpdateCheckResult CheckForUpdate(string currentVersion)
}

/// <inheritdoc/>
public UpdateCheckResult? TryGetCachedResult(string currentVersion)
public UpdateCheckResult TryGetCachedResult(string currentVersion)
{
bool isGitInstallation = IsGitInstallation();
string gitBranch = isGitInstallation ? GetGitUpdateBranch(currentVersion) : "main";
Expand Down
3 changes: 1 addition & 2 deletions MCPForUnity/Editor/Tools/ManageScene.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1713,8 +1713,7 @@ private static object ValidateScene(bool autoRepair)
}

var prefabStatus = PrefabUtility.GetPrefabInstanceStatus(go);
if (prefabStatus == PrefabInstanceStatus.MissingAsset ||
prefabStatus == PrefabInstanceStatus.Disconnected)
if (prefabStatus == PrefabInstanceStatus.MissingAsset)
{
brokenPrefabs++;
if (issues.Count < maxIssues)
Expand Down