Skip to content

Conversation

@TxCorpi0x
Copy link

@TxCorpi0x TxCorpi0x commented Oct 13, 2025

Description

This pull request introduces a new set of commands for managing and re-parsing bridge module transactions, along with improvements to error handling and logging. The main changes add a new bridge command with a subcommand for re-scanning bridge transactions, integrate it into the main parse CLI, and enhance the reliability of transaction querying with retry logic for transient errors.

New Bridge Module Commands:

  • Added a new bridge command to the CLI, with a txs subcommand that allows re-scanning and overwriting all bridge transactions within a specified block height range. This includes chunked processing, detailed error and summary logging, and statistics tracking.

Integration with Parse CLI:

  • Registered the new bridge command in the main parse CLI, making it available alongside other module commands.

Reliability and Error Handling Improvements:

  • Enhanced the QueryTxs utility function to include retry logic with exponential backoff for transient errors (timeouts, gateway errors, etc.), improving robustness when querying transactions from the node.

This change is Reviewable

@TxCorpi0x TxCorpi0x requested a review from a team as a code owner October 13, 2025 14:07
@TxCorpi0x TxCorpi0x requested review from masihyeganeh, miladz68 and ysv and removed request for a team October 13, 2025 14:07
Copy link
Author

@TxCorpi0x TxCorpi0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 7 unresolved discussions (waiting on @masihyeganeh, @miladz68, and @ysv)

miladz68
miladz68 previously approved these changes Oct 16, 2025
Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miladz68 reviewed 2 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @masihyeganeh and @ysv)

ysv
ysv previously approved these changes Oct 20, 2025
Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 2 of 4 files at r1, 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miladz68 reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)


cmd/parse/bridge/txs.go line 187 at r3 (raw file):

			rangeCount := (endHeight - startHeight + checkSize - 1) / checkSize

			log.Info().Msg("============================================")

remove these decorative log lines for a more professional looking logs.

Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @masihyeganeh and @TxCorpi0x)


cmd/parse/bridge/txs.go line 51 at r3 (raw file):

			// Log processing summary header
			log.Info().Msg("=== Bridge Transaction Processing Summary ===")

remove this as well.

Copy link
Author

@TxCorpi0x TxCorpi0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @masihyeganeh, @miladz68, and @ysv)


cmd/parse/bridge/txs.go line 51 at r3 (raw file):

Previously, miladz68 (milad) wrote…

remove this as well.

Done.


cmd/parse/bridge/txs.go line 187 at r3 (raw file):

Previously, miladz68 (milad) wrote…

remove these decorative log lines for a more professional looking logs.

Done.

@ysv ysv requested a review from miladz68 October 21, 2025 10:49
Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @masihyeganeh and @miladz68)

Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miladz68 reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@TxCorpi0x TxCorpi0x merged commit 73f3e89 into chains/coreum-v0.50.x Oct 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants