-
Notifications
You must be signed in to change notification settings - Fork 4
Bridge Parse Transactions Re-Scan CMD #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TxCorpi0x
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 7 unresolved discussions (waiting on @masihyeganeh, @miladz68, and @ysv)
miladz68
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miladz68 reviewed 2 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @masihyeganeh and @ysv)
ysv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ysv reviewed 2 of 4 files at r1, 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
miladz68
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miladz68 reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
miladz68
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)
cmd/parse/bridge/txs.go line 187 at r3 (raw file):
rangeCount := (endHeight - startHeight + checkSize - 1) / checkSize log.Info().Msg("============================================")
remove these decorative log lines for a more professional looking logs.
miladz68
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @masihyeganeh and @TxCorpi0x)
cmd/parse/bridge/txs.go line 51 at r3 (raw file):
// Log processing summary header log.Info().Msg("=== Bridge Transaction Processing Summary ===")
remove this as well.
TxCorpi0x
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @masihyeganeh, @miladz68, and @ysv)
cmd/parse/bridge/txs.go line 51 at r3 (raw file):
Previously, miladz68 (milad) wrote…
remove this as well.
Done.
cmd/parse/bridge/txs.go line 187 at r3 (raw file):
Previously, miladz68 (milad) wrote…
remove these decorative log lines for a more professional looking logs.
Done.
ysv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ysv reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @masihyeganeh and @miladz68)
miladz68
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miladz68 reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
Description
This pull request introduces a new set of commands for managing and re-parsing bridge module transactions, along with improvements to error handling and logging. The main changes add a new
bridgecommand with a subcommand for re-scanning bridge transactions, integrate it into the main parse CLI, and enhance the reliability of transaction querying with retry logic for transient errors.New Bridge Module Commands:
bridgecommand to the CLI, with atxssubcommand that allows re-scanning and overwriting all bridge transactions within a specified block height range. This includes chunked processing, detailed error and summary logging, and statistics tracking.Integration with Parse CLI:
bridgecommand in the main parse CLI, making it available alongside other module commands.Reliability and Error Handling Improvements:
QueryTxsutility function to include retry logic with exponential backoff for transient errors (timeouts, gateway errors, etc.), improving robustness when querying transactions from the node.This change is