Skip to content

Conversation

@masihyeganeh
Copy link
Contributor

@masihyeganeh masihyeganeh commented Jul 21, 2025

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@masihyeganeh masihyeganeh requested a review from a team as a code owner July 21, 2025 19:09
@masihyeganeh masihyeganeh requested review from TxCorpi0x, miladz68 and ysv and removed request for a team July 21, 2025 19:09
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 5.71429% with 33 lines in your changes missing coverage. Please review.

Project coverage is 52.50%. Comparing base (b6fe2dd) to head (b799a98).

Files with missing lines Patch % Lines
app/upgrade/v6/denom_symbol.go 0.00% 30 Missing ⚠️
app/upgrade/v6/upgrade.go 25.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b6fe2dd) and HEAD (b799a98). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b6fe2dd) HEAD (b799a98)
coreum 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1172       +/-   ##
===========================================
- Coverage   63.67%   52.50%   -11.18%     
===========================================
  Files         163      149       -14     
  Lines       18521    16611     -1910     
===========================================
- Hits        11793     8721     -3072     
- Misses       5581     6733     +1152     
- Partials     1147     1157       +10     
Flag Coverage Δ
coreum ?
coreum-integration-tests-modules 52.50% <5.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@masihyeganeh masihyeganeh changed the title Denom symbol migration testing Jul 22, 2025
@masihyeganeh masihyeganeh deleted the masih/denom-symbol-migration branch July 22, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants