fix: default selfImprovement.enabled to true when config block omitted#391
Merged
fix: default selfImprovement.enabled to true when config block omitted#391
Conversation
#375) When the selfImprovement config block is entirely omitted from plugin config, enabled defaults to false, preventing self_improvement_* tools from registering. This is inconsistent with the behavior when the block IS provided but enabled is not set, which correctly defaults to true via the !== false check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
这个修复方向是对的,我这边没有看到阻塞合并的问题。它确实命中了 #375 的核心原因: 我只想补一个非阻塞备注: |
…mitted When the selfImprovement config block is entirely omitted, beforeResetNote, skipSubagentBootstrap, and ensureLearningFiles now default to true — matching the behavior when an empty selfImprovement object is provided. Addresses review feedback on #391. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Good catch — just pushed a follow-up commit ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selfImprovementconfig block is entirely omitted from plugin config,enableddefaults tofalse, which prevents all threeself_improvement_*tools from registeringenabledis not explicitly set, it correctly defaults totruevia the!== falsecheckenabled: falsetoenabled: trueso the behavior is consistent regardless of whether the config block is presentDetails
In
index.tsaround line 3830, the config parsing forselfImprovementhas two branches:selfImprovementis an object:enableddefaults totrue(via!== false)selfImprovementis omitted:enabledwas hardcoded tofalse(the bug)Verified by testing on a live OpenClaw instance: adding
selfImprovement: { enabled: true }to the config makes all 3 self-improvement tools appear, confirming the tools work — they just weren't registering due to the default.Fixes #375
🤖 Generated with Claude Code