Fixed runserver warnings/errors on various components and pages#636
Fixed runserver warnings/errors on various components and pages#636Bcastillo44 wants to merge 12 commits into
Conversation
0xZakk
left a comment
0xZakk
left a comment
There was a problem hiding this comment.
@Bcastillo44 Looks like you made some good progress, but I'm still seeing a lot of errors
You created a Pipfile in the root of the repo, can you get rid of that?
Also, it looks like you checked in the environment variables!!! Can you delete that immediately?!
This reverts commit e381927.
…pperPlatform/CoTrip into runserver-errors-local-application
0xZakk
left a comment
0xZakk
left a comment
There was a problem hiding this comment.
@Bcastillo44 This looks better and thank you for removing the environment variables!
I'm still seeing a lot of errors output in the console when I run the server. Any idea why?
0xZakk
left a comment
0xZakk
left a comment
There was a problem hiding this comment.
I'm getting these last three errors:
Compiled with warnings.
./src/pages/OnboardingPage/FilterSettingsForm/FilterSettingsForm.js
Line 42:24: Expected to return a value in arrow function array-callback-return
./src/pages/HomePageOldUser/HomePageOldUser.js
Line 76:7: 'handleClick' is assigned a value but never used no-unused-vars
./src/pages/HomePage/HomePage.js
Line 77:7: 'handleClick' is assigned a value but never used no-unused-vars
Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.
Otherwise, this is a HUUUUUUUUGE improvement!
0xZakk
left a comment
0xZakk
left a comment
There was a problem hiding this comment.
@Bcastillo44 Can you update this with develop and fix any merge conflicts?
How do I do that? |
0xZakk
left a comment
0xZakk
left a comment
There was a problem hiding this comment.
Your branch has conflicts with develop - merge develop into this branch, fix the conflicts, then update this PR
| <<<<<<< HEAD | ||
| <a href="./home">New User Sample</a> | ||
| <br></br> | ||
| <a href="./home-old-user">Old User Sample</a> | ||
| ======= | ||
| >>>>>>> develop |
There was a problem hiding this comment.
Looks like you committed a merge conflict! Can you fix this please?
0xZakk
left a comment
0xZakk
left a comment
There was a problem hiding this comment.
Merge develop into this branch and then merge this PR
2 participants
Related Issue (include '#'):
Runserver Errors on Local application #631
Description of changes made:
Fixed runserver warnings/errors on various components and pages
Is the feature complete/bug resolved/etc..:
Not all bugs are resolved
Any known bugs/strange behavior:
Is there specific feedback you would like on these changes:
Screenshot(s):