-
Notifications
You must be signed in to change notification settings - Fork 12
Final project cotripper #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
81a6210
3f2fc52
fc49f11
5eb9099
592264f
6e5dbe5
7e2ad98
77fb404
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| [[source]] | ||
| name = "pypi" | ||
| url = "https://pypi.org/simple" | ||
| verify_ssl = true | ||
|
|
||
| [dev-packages] | ||
|
|
||
| [packages] | ||
|
|
||
| [requires] | ||
| python_version = "3.8" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| .wrapper { | ||
| text-align: center; | ||
| } | ||
|
|
||
| h1{ | ||
| display: inline-block; | ||
| } | ||
|
|
||
|
Comment on lines
+1
to
+8
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you use the css naming convention outlined in the readme? These styles will clash with styles throughout the rest of the app |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import React from 'react'; | ||
|
WRNoble marked this conversation as resolved.
|
||
| import './GroupPage.css'; | ||
| import GroupCard from "../GroupCard/GroupCard"; | ||
| import Navbar from '../Navbar/Navbar'; | ||
| import Footer from '../Footer/Footer'; | ||
| import card1 from "assets/images/card-image-3.png"; | ||
| import card2 from "assets/images/card-image-2.png"; | ||
| import card3 from "assets/images/card-image.png"; | ||
| import people from "assets/images/profile_default.svg"; | ||
|
|
||
|
|
||
| const GroupPage = props => { | ||
|
|
||
| return ( | ||
| <div> | ||
| <Navbar | ||
| to={"/member-page"} | ||
| profileImage={people} | ||
| /> | ||
|
|
||
|
|
||
| <div className='wrapper'> | ||
| <h1>Groups You Can Join!</h1> | ||
| </div> | ||
| <div className="HomePage__group-cards-container"> | ||
| <span className="HomePage__groupcard-1"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should never have a number in a class - by definition, classes should apply to multiple elements (as opposed to IDs) Also, make sure your names are consistent (i.e. |
||
| <GroupCard | ||
| name="DIY with your kids" | ||
| members="98" | ||
| location="Boston, MA" | ||
| picture={card1} | ||
| /> | ||
| </span> | ||
| <span className="HomePage__groupcard-2"> | ||
| <GroupCard name="Mystery Stories!" members="213" location="NYC" picture={card2} /> | ||
| </span> | ||
| <span className="HomePage__groupcard-3"> | ||
| <GroupCard name="Bay Cruise" members="98" location="Lisbon" picture={card3} /> | ||
| </span> | ||
| </div> | ||
| <Footer /> | ||
| </div> | ||
|
WRNoble marked this conversation as resolved.
|
||
| ) | ||
| } | ||
|
|
||
|
|
||
| export default GroupPage | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| import React from "react"; | ||
|
WRNoble marked this conversation as resolved.
|
||
| import { storiesOf } from "@storybook/react"; | ||
Uh oh!
There was an error while loading. Please reload this page.