CASMNET-2301-fixing-VRF-test

[marumugam-hpe]

Summary and Scope

This change was made to allow customization of VRF name used for customers. Only canu test was modified.

Previously canu test had a hard coded Customer VRF. This was both wrong in that the PoR name is CSM, and didn't allow for customization. The new code defaults the VRF to CSM but allows command-line based customization.

This code also fixes a logic issue in the VRF neighbors test. Previously the test checked for a return of No OSPF Neighbors from the command line. The original test allowed errors where no VRF was configured to show up as a test success. The new logic catches both no neighbors and misconfiguration errors more effectively, though the framework does not allow dissecting which specific error occurred.

Issues and Related PRs

https://jira-pro.it.hpe.com:8443/browse/CASMNET-2301

Testing

Tested on spine switch 001/002 on Surtur.

[spillerc-hpe]

I installed your RPM on surtur, there is a second OSPF test that has Customer hard coded.

| 45 | sw-spine-002    | OSPF vrf Customer EXSTART Neighbors          | PASS     |                                                                                            |

Looks like your change is also needed here

canu/canu/test/aruba/test_suite.yaml

Lines 314 to 327 in 1853f96

	- name: OSPF vrf Customer EXSTART Neighbors
	task: show ip ospf neighbors vrf Customer
	test: ncontains
	pattern: EXSTART
	err_msg: |
	OSPF neighbors found in EXSTART state.
	This is commonly caused by a MTU mismatch between neighbors.
	Execute "show ip interface" to see the MTU of L3 interfaces.
	device:
	- leaf
	- leaf-bmc
	- cdu
	- spine
	pre_install: True

Somewhat distressingly the test passes because even though the Customer VRF isn't configured, the output does indeed not contain EXSTART.

sw-spine-001# show ip ospf neighbors vrf Customer
VRF Customer is not configured.

[trad511]

@marumugam-hpe good work. In the future a bit more description in the PR is appropriate. I correct it in this one.