Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMMON-407: Update prometheus URL to victoria-metrics #13

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

arka-pramanik-hpe
Copy link
Contributor

@arka-pramanik-hpe arka-pramanik-hpe commented Jul 4, 2024

Summary and Scope

Update prometheus URL to victoria-metrics url because from CSM 1.6 prometheus will be replaced with victoria-metrics.

The end result is that many of the GUI functions do not work correctly as Kiali cannot connect to Prometheus.
This PR corrects the Prometheus URL used by Kiali.

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Testing

List the environments in which these changes were tested.

Tested on:

Fanta

Test description:

Prometheus url is replaced with vmselect in victoria-metrics from CSM-1.6
 
ncn-m001:/mnt/developer/shreni # kubectl get pod -n sysmgmt-health | grep select
vmselect-vms-0                                                   1/1     Running            0          8m53s
vmselect-vms-1                                                   1/1     Running            0          8m53s
 
-------------------------------------------------------------------------------------------------------------------
 
ncn-m001:/mnt/developer/shreni # kubectl -n istio-system get kiali -o yaml | yq4 eval '.. | select(has("prometheus"))'
grafana:
  url: https://grafana.cmn.fanta.hpc.amslabs.hpecorp.net/
prometheus:
  url: http://vmselect-vms.sysmgmt-health.svc.cluster.local:8481/select/0/prometheus
tracing:
  enabled: false

image

image

image

image

@spillerc-hpe
Copy link
Contributor

Have other features of Kiali beyond the mesh topology graph been tested? Presumably the Inbound/Outbound traffic metrics still work?

@shreni123
Copy link

Have other features of Kiali beyond the mesh topology graph been tested? Presumably the Inbound/Outbound traffic metrics still work?

@spillerc-hpe , I can see Inbound/Outbound traffic metrics, will add screenshots for that as well. Thanks!

Copy link

@dborman-hpe dborman-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arka-pramanik-hpe arka-pramanik-hpe merged commit 753634a into master Jul 9, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants