CASMTRIAGE-6885 - fix etc/resolv.conf resolution for broken symlinks. #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
If the /etc/resolv.conf file that existed in the original image was a broken symbolic link, the process of saving off the original and restoring it at the end of the operation failed. Now it checked directly for a symbolic link and also moves that regardless of if the link is broken or valid.
I also discovered some issues with the complete/failed flag files so those are now straightened out as well.
Issues and Related PRs
Testing
Tested on:
Tyr
Test description:
I installed the new test version of the image on Tyr and ran all combinations of remote and local x86 and aarch64 customize jobs, insuring that the resolv.conf file was correctly handled and the failed/complete flags behaved as they are supposed to.
Risks and Mitigations
This is a moderate risk change, but required for the customize jobs to function correctly.
Pull Request Checklist