Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMTRIAGE-6885 - fix etc/resolv.conf resolution for broken symlinks. #80

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

dlaine-hpe-2
Copy link
Contributor

Summary and Scope

If the /etc/resolv.conf file that existed in the original image was a broken symbolic link, the process of saving off the original and restoring it at the end of the operation failed. Now it checked directly for a symbolic link and also moves that regardless of if the link is broken or valid.

I also discovered some issues with the complete/failed flag files so those are now straightened out as well.

Issues and Related PRs

Testing

Tested on:

  • Tyr

Test description:

I installed the new test version of the image on Tyr and ran all combinations of remote and local x86 and aarch64 customize jobs, insuring that the resolv.conf file was correctly handled and the failed/complete flags behaved as they are supposed to.

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? N
  • Were continuous integration tests run? If not, why? N
  • Was upgrade tested? If not, why? N
  • Was downgrade tested? If not, why? N
  • Were new tests (or test issues/Jiras) created for this change? N

Risks and Mitigations

This is a moderate risk change, but required for the customize jobs to function correctly.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable

@dlaine-hpe-2 dlaine-hpe-2 requested a review from a team as a code owner April 18, 2024 15:32
@dlaine-hpe-2 dlaine-hpe-2 merged commit 741d147 into master Apr 18, 2024
6 checks passed
@dlaine-hpe-2 dlaine-hpe-2 deleted the CASMTRIAGE-6885 branch April 18, 2024 17:38
dlaine-hpe-2 added a commit that referenced this pull request Apr 18, 2024
…-1713461944

[chore] master -> develop from PR #80 (CASMTRIAGE-6885)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants