Fix proposal for #9063 and #9058 #9127
Open
+27
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoidLeech
added
area: rendering
|
Oops. Please don't accept the PR yet. I've noticed a rendering issue with gears, and factory panels. I'm looking into it, and performing more tests... |
|
Should be fine now. |
Reverting to vertex-only transform (see issue)
TropheusJ
reviewed
Oct 23, 2025
| @Nullable | ||
| @SuppressWarnings("unchecked") | ||
| default T getBlockEntity(BlockGetter worldIn, BlockPos pos) { | ||
| if (worldIn == null) |
There was a problem hiding this comment.
this will likely just obfuscate other issues, please undo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix proposal for issues #9063 and #9058.
Note
More information about the nature of the proposals, as well as some screenshots of the results, can be found in the respective issues.