Skip to content

Conversation

@VoidLeech
Copy link
Collaborator

@VoidLeech VoidLeech commented Sep 26, 2025

  • Fixes package filters with an empty address string still accepting package filters.
  • Fixes attribute filters with empty attribute lists always and only accepting attribute filters, irrespective of whitelist mode (doesn't match traditional definitions of 'matches any', 'matches all', and 'not matches any' which would result in nothing, everything, everything)
  • Fixes - Named filters lose their name if saved with no items or attributes in the filter #5017 by undoing 'Fixed Filters and Attribute Filters not stacking with unmodified, equivalent stacks' from ffa85dc, because that also led to:
  • Fixes empty list filters on allow mode and ignore data (per the allow-mode summary, this should reject everything) still accepting list filters: in the existing code for FilterItemStack, there is a meaningful difference between 'stack has no nbt' and 'stack has the default value as nbt', but the latter is currently unobtainable:
    public static FilterItemStack of(ItemStack filter) {
    if (filter.hasTag() && filter.getItem() instanceof FilterItem item) {
    trimFilterTag(filter);
    return item.makeStackWrapper(filter);
    }
    return new FilterItemStack(filter);
    }

@VoidLeech VoidLeech added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels Sep 26, 2025
@VoidLeech VoidLeech added the pr type: feature PR adds a new feature or changes an existing feature label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr flag: simple PR has minimal changes pr type: feature PR adds a new feature or changes an existing feature pr type: fix PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant