Skip to content

Conversation

@mollo010
Copy link
Contributor

This is related to the pull request mc1.20.1/dev...hlysine:Create:fix/crafting-remaining-item.
It applies all this Some items in Minecraft contains "crafting remaining items" which are left behind when the item is used in crafting, e.g. empty buckets are left behind when crafting a cake with milk buckets. This is also how mods implement inconsumable crafting ingredients. However, over half of Create's recipe types do not respect this method, causing unexpected results such as #4853 and #4963.

Seeing that this issue has been in Create for years and I'm already patching one aspect of it in Create: Connected, I've decided to upstream the patch and fix all recipe types once and for all.

Recipe types that already return crafting remaining items include:

Automated shaped crafting
Mechanical crafting
Mixing
Compacting

Recipe types that did not return remaining items but are fixed in this PR include:

Crushing
Deploying
Fan processing (bulk blasting and smoking removes the remainder to be consistent with vanilla furnace behavior)
Manual item application
Milling
Pressing
Sandpaper polishing
Sawing

For your convenience, here's a datapack that adds all types of recipes for lava buckets, so you can verify that an empty bucket remains after processing: crafting-remaining-items-data.zip

To the current main branch and resolves the merge conflicts

@TheVigilantHawk
Copy link

This looks clean and well-implemented. Conflicts look resolved related to #4853 and #4963.
Highly recommend to push up.

@VoidLeech
Copy link
Collaborator

Conflicts look resolved related to #4853 and #4963.

These were already solved; this PR/the original at #8556 makes other recipes types from Create also return remainders.

@VoidLeech VoidLeech added pr type: fix PR fixes a bug pr type: feature PR adds a new feature or changes an existing feature labels Oct 20, 2025
Copy link
Collaborator

@TropheusJ TropheusJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nitpicks, functionality looks good

@mollo010
Copy link
Contributor Author

@TropheusJ I addressed the issue you highlighted

@mollo010 mollo010 requested a review from TropheusJ October 23, 2025 10:14
@IThundxr IThundxr enabled auto-merge October 23, 2025 22:49
@IThundxr IThundxr added this pull request to the merge queue Oct 23, 2025
Merged via the queue into Creators-of-Create:mc1.20.1/dev with commit d9d0507 Oct 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr type: feature PR adds a new feature or changes an existing feature pr type: fix PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants