-
Notifications
You must be signed in to change notification settings - Fork 1.2k
applied Fix from hlysien to updated main #9372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
IThundxr
merged 5 commits into
Creators-of-Create:mc1.20.1/dev
from
mollo010:mc1.20.1/dev
Oct 23, 2025
Merged
applied Fix from hlysien to updated main #9372
IThundxr
merged 5 commits into
Creators-of-Create:mc1.20.1/dev
from
mollo010:mc1.20.1/dev
Oct 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TropheusJ
approved these changes
Oct 22, 2025
Collaborator
TropheusJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nitpicks, functionality looks good
src/main/java/com/simibubi/create/content/equipment/sandPaper/SandPaperItem.java
Outdated
Show resolved
Hide resolved
src/main/java/com/simibubi/create/content/equipment/sandPaper/SandPaperItem.java
Outdated
Show resolved
Hide resolved
src/main/java/com/simibubi/create/content/kinetics/deployer/BeltDeployerCallbacks.java
Outdated
Show resolved
Hide resolved
src/main/java/com/simibubi/create/content/kinetics/deployer/ManualApplicationRecipe.java
Outdated
Show resolved
Hide resolved
src/main/java/com/simibubi/create/content/kinetics/press/MechanicalPressBlockEntity.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@TropheusJ I addressed the issue you highlighted |
Merged
via the queue into
Creators-of-Create:mc1.20.1/dev
with commit Oct 23, 2025
d9d0507
1 check passed
This was referenced Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the pull request mc1.20.1/dev...hlysine:Create:fix/crafting-remaining-item.
It applies all this Some items in Minecraft contains "crafting remaining items" which are left behind when the item is used in crafting, e.g. empty buckets are left behind when crafting a cake with milk buckets. This is also how mods implement inconsumable crafting ingredients. However, over half of Create's recipe types do not respect this method, causing unexpected results such as #4853 and #4963.
Seeing that this issue has been in Create for years and I'm already patching one aspect of it in Create: Connected, I've decided to upstream the patch and fix all recipe types once and for all.
Recipe types that already return crafting remaining items include:
Recipe types that did not return remaining items but are fixed in this PR include:
For your convenience, here's a datapack that adds all types of recipes for lava buckets, so you can verify that an empty bucket remains after processing: crafting-remaining-items-data.zip
To the current main branch and resolves the merge conflicts