feat: Test suite – interest accrual over time#75
Open
observerr411 wants to merge 10 commits intoCreditra:mainfrom
Open
feat: Test suite – interest accrual over time#75observerr411 wants to merge 10 commits intoCreditra:mainfrom
observerr411 wants to merge 10 commits intoCreditra:mainfrom
Conversation
Contributor
|
resolve the conflicts |
…errors - Added last_accrual_timestamp field to CreditLineData struct - Removed unnecessary unit return types (-> ()) - Fixed inconsistent digit grouping in MAX_INTEREST_RATE_BPS constant - Removed duplicate #[cfg(test)] attribute in interest_accrual tests - All tests passing and clippy checks clean
Contributor
|
resolve the conflict |
…coverage improvements
- Add credit_limit validation (must be > 0) - Add interest_rate_bps validation (must be <= 10000) - Add risk_score validation (must be <= 100) - Add duplicate active credit line check - Update panic messages to match test expectations - All 92 tests passing
The dtolnay/rust-toolchain@stable action already specifies the toolchain in the action reference, so specifying it again in the 'with' section causes a conflict. Removed the redundant toolchain parameter.
Fixed multi-line formatting for the storage get operation to comply with rustfmt standards.
Contributor
|
@observerr411 please resolve the conflicts |
…ssing risk_score validation
Contributor
|
please resolve the conflicts |
Contributor
|
@observerr411 Can you resolve the conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #34