Skip to content

feat: prod 프로필 추가 및 설정 정리#162

Merged
CheChe903 merged 1 commit intodevelopfrom
feat/161
Apr 5, 2026
Merged

feat: prod 프로필 추가 및 설정 정리#162
CheChe903 merged 1 commit intodevelopfrom
feat/161

Conversation

@CheChe903
Copy link
Copy Markdown
Member

No description provided.

@CheChe903 CheChe903 self-assigned this Apr 5, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이번 변경 사항은 애플리케이션의 운영 환경 배포를 위한 프로필 설정 추가와 기존 설정 파일의 관리 방식을 개선하는 데 목적이 있습니다. 또한, 불필요한 테스트 코드 중복을 제거하여 코드베이스의 유지보수성을 향상시켰습니다.

Highlights

  • 운영 환경 설정 추가: 운영 환경(prod)을 위한 application-prod.yml 파일을 추가하여 데이터베이스 및 CORS 설정을 구성했습니다.
  • 설정 파일 관리 최적화: .gitignore에서 민감 정보가 포함된 설정 파일을 명시적으로 관리하도록 변경하고, 기본 프로필 설정을 정리했습니다.
  • 테스트 코드 정리: 중복된 테스트 클래스 선언을 제거하여 테스트 코드의 가독성을 높였습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a production configuration file, updates the .gitignore file, and removes duplicate test code in the CrewDocumentServiceTest class. The review feedback highlights a security risk regarding the .gitignore pattern and recommends a safer Hibernate DDL setting for the production environment to prevent accidental data loss.

Comment on lines +13 to +16
ddl-auto: update
properties:
hibernate:
dialect: org.hibernate.dialect.MySQL8Dialect
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

운영 환경(prod)에서 ddl-auto: update 설정은 의도치 않은 스키마 변경으로 인한 데이터 유실 위험이 있어 validate 사용을 권장합니다. 또한, Hibernate 5.x 이상에서는 Dialect를 자동으로 감지하므로 불필요한 명시적 설정을 제거하여 유지보수성을 높이는 것이 좋습니다.

      ddl-auto: validate

.vscode/

application-*.yml
src/main/resources/application-private.yml
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

.gitignore에서 application-*.yml 와일드카드 패턴을 제거하고 특정 파일만 지정할 경우, 보안 정보가 포함된 다른 프로필 설정 파일이 실수로 Git에 추적될 위험이 있습니다. 보안을 위해 기존의 와일드카드 패턴을 유지하는 것을 권장합니다.

application-*.yml

@CheChe903 CheChe903 merged commit d0161a8 into develop Apr 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant