✨(feat) update storage to support S3 and R2 integration#5
Open
RajikaKeminda wants to merge 1 commit into
Open
Conversation
|
✅ ESLint check passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the configuration for AWS services and introduces support for S3-compatible storage services like Cloudflare R2. The changes involve updating environment variables, modifying service classes to use the new configuration structure, and adding a dedicated configuration section for S3.
Configuration Updates:
api-backend/.env.example: Added new environment variables for S3-compatible storage (S3_ACCESS_KEY,S3_SECRET_KEY,S3_ENDPOINT_URL,S3_BUCKET_NAME, andS3_REGION) and removedAWS_BUCKET_REGIONandAWS_MEETING_BOT_BUCKET_NAME.api-backend/src/config/configuration.ts: Updated theawsconfiguration object to replacebucketRegionwithregionand removedmeetingBotBucketName. Added a news3configuration object to handle S3-specific settings.Service Class Modifications:
api-backend/src/aws/aws.service.ts: Updated theAwsServiceclass to use the news3configuration for S3-compatible storage, includingendpoint,accessKey,secretKey,region, andbucketName. [1] [2]api-backend/src/aws/ecs.service.ts: Modified theECSClientServiceclass to use the updatedaws.regionconfiguration instead of the removedaws.bucketRegion.