Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the package and version when unzipping fails #922

Merged
merged 6 commits into from
Feb 1, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions CycloneDX/Services/NugetV3Service.cs
Original file line number Diff line number Diff line change
@@ -316,12 +316,20 @@ private async Task<NuspecModel> GetNuspec(string name, string version, string nu
await resource.CopyNupkgToStreamAsync(name, packageVersion, packageStream, _sourceCacheContext,
_logger, _cancellationToken);

using PackageArchiveReader packageReader = new PackageArchiveReader(packageStream);
nuspecModel.nuspecReader = await packageReader.GetNuspecReaderAsync(_cancellationToken);
try
{
using PackageArchiveReader packageReader = new PackageArchiveReader(packageStream);
nuspecModel.nuspecReader = await packageReader.GetNuspecReaderAsync(_cancellationToken);

if (!_disableHashComputation)
if (!_disableHashComputation)
{
nuspecModel.hashBytes = ComputeSha215Hash(packageStream);
}
}
catch (InvalidDataException)
{
nuspecModel.hashBytes = ComputeSha215Hash(packageStream);
Console.Error.WriteLine($"Unable to extract the nuget package: {name} - {version}");
throw;
}
}
else