fix: manufacture. Reasoning: https://cyclonedx.org/docs/… #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barblin
force-pushed
the
fix/manufacture-deprecated
branch
from
09c53e6 to
21f7eb7
Compare
|
Hey, we found that manufacture was empty if all fields are empty. We think the field should not be added in the SBOM at all if it contains no fields. Also, we found that you use https://cyclonedx.org/docs/1.6/json/#metadata_manufacture, which is deprecated. Probably https://cyclonedx.org/docs/1.6/json/#metadata_manufacturer is the appropreate replacement. |
barblin
force-pushed
the
fix/manufacture-deprecated
branch
from
21f7eb7 to
0cd9264
Compare
barblin
changed the title
|
@skhokhlov what do you think? |
skhokhlov
reviewed
Feb 4, 2025
src/test/groovy/org/cyclonedx/gradle/utils/OrganizationalEntityUtilTest.groovy
Outdated
Show resolved
Hide resolved
…adata_manufacture deprecated. Use https://cyclonedx.org/docs/1.6/json/#metadata_manufacturer instead Signed-off-by: Johannes Özkan Preisinger <[email protected]>
barblin
force-pushed
the
fix/manufacture-deprecated
branch
from
0cd9264 to
5bce04b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…1.6/json/#metadata_manufacture deprecated. Use https://cyclonedx.org/docs/1.6/json/#metadata_manufacturer instead