feat(payments): include sol_price_usd in GET /payments/:id#2
Open
relayhop wants to merge 1 commit into
Open
Conversation
The widget polls GET /payments/:id for status; previously sol_price_usd was only returned on creation, so the widget had to make a separate /api/price/sol call. Including it here lets the widget read the price directly from the payment object (matching the issue's expected behavior), saving one HTTP roundtrip per checkout. Refs Cypher-CP0#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1 (backend portion).
Problem
The widget polls
GET /api/payments/:idfor status, butsol_price_usdis only returned byPOST /api/payments/create. So the widget has to make a separateGET /api/price/solcall to read the price — an extra roundtrip plus a price that may not match what the backend computed at payment creation time.Change
Include
sol_price_usd: await getSolPrice()in the GET response, mirroring what create already returns. Cache (30s) prevents this from hammering the price API.Result
The widget can read
payment.sol_price_usddirectly (matching the issue Expected behavior: Read sol_price_usd from the payment object returned by the backend).A matching widget PR (read from payment object instead of /api/price/sol) will follow on Cypher-CP0/fluxpay-widget.