Skip to content

Homescreen UI revamp#114

Open
chaitika wants to merge 5 commits into
CypherCommons:masterfrom
chaitika:homescreen-ui-revamp
Open

Homescreen UI revamp#114
chaitika wants to merge 5 commits into
CypherCommons:masterfrom
chaitika:homescreen-ui-revamp

Conversation

@chaitika

@chaitika chaitika commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Redesign the Home Screen as per design document for both light and dark themes
image image

Copilot AI review requested due to automatic review settings June 4, 2026 13:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the wallet list/home UI styling and theming, adds new iconography and custom fonts, and aligns several loading indicators/buttons with the active theme (including dark mode support).

Changes:

  • Reworks WalletsList header/actions/empty state UI (new toast, icons, balance formatting, and styling).
  • Adds Clash Grotesk font integration (RN assets config + iOS/Android manifests/plists) and introduces ClashFont constants.
  • Improves theme usage across the app (dark theme export/use, themed activity indicators, themed settings button, color-scheme switching).

Reviewed changes

Copilot reviewed 20 out of 30 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
screen/wallets/WalletsList.tsx New wallet header/actions/empty state UI, toast behavior, and theme-driven styles/icons
screen/UnlockWith.tsx Theme-colored ActivityIndicator
react-native.config.js Registers font assets for React Native linking
navigation/LazyLoadingIndicator.tsx Theme-colored ActivityIndicator
navigation/DetailViewScreensStack.tsx Passes theme colors into SettingsButton
loc/en.json Adds new strings for empty state, toast, and button labels
ios/link-assets-manifest.json Adds generated font linking manifest for iOS
ios/Widgets/Info.plist Registers Clash fonts for the Widgets target
ios/Shroud/Info.plist Registers Clash fonts for the app target
ios/Shroud.xcodeproj/project.pbxproj Adds font files to Xcode project resources
constants/fonts.ts Adds ClashFont family constants and documentation
components/themes.ts Adds new theme color tokens; exports BlueDarkTheme and updates dark palette
components/icons/ShieldReceiveIcon.tsx New SVG icon component for empty state
components/icons/SettingsButton.tsx Replaces RNE icon with themed SVG button
components/icons/SearchIcon.tsx New SVG icon component
components/icons/ReceiveArrowIcon.tsx New SVG icon component
components/icons/QRScanIcon.tsx New SVG icon component
components/icons/PayArrowIcon.tsx New SVG icon component
android/link-assets-manifest.json Adds generated font linking manifest for Android
App.tsx Adds color-scheme based theming and moves indexer/bridge init into effects

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread screen/wallets/WalletsList.tsx
Comment thread screen/wallets/WalletsList.tsx
Comment thread screen/wallets/WalletsList.tsx
Comment thread screen/wallets/WalletsList.tsx
Comment thread screen/wallets/WalletsList.tsx Outdated
Comment thread screen/wallets/WalletsList.tsx
Comment thread App.tsx Outdated
Comment thread App.tsx
Comment thread constants/fonts.ts Outdated
@chaitika chaitika force-pushed the homescreen-ui-revamp branch from 15dde2b to 11e04b8 Compare June 10, 2026 15:53
@chaitika chaitika marked this pull request as ready for review June 10, 2026 15:58
Copilot AI review requested due to automatic review settings June 10, 2026 15:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 9 comments.

Comment thread screen/wallets/WalletsList.tsx Outdated
Comment thread screen/wallets/WalletsList.tsx
Comment thread screen/wallets/WalletsList.tsx
Comment thread screen/wallets/WalletsList.tsx
Comment thread screen/wallets/WalletsList.tsx
Comment thread screen/wallets/WalletsList.tsx
Comment thread ios/Shroud.xcodeproj/project.pbxproj Outdated
Comment thread components/icons/SettingsButton.tsx Outdated
Comment thread loc/en.json Outdated
@chaitika chaitika force-pushed the homescreen-ui-revamp branch from 11e04b8 to fe07f74 Compare June 16, 2026 13:58
Copilot AI review requested due to automatic review settings June 16, 2026 15:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings June 16, 2026 16:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 22 changed files in this pull request and generated 5 comments.

Comment thread screen/wallets/WalletsList.tsx
Comment thread screen/wallets/WalletsList.tsx
Comment thread screen/wallets/WalletsList.tsx
Comment thread App.tsx Outdated
Comment thread tests/e2e/05-send.spec.js
@notTanveer

notTanveer commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

overflow error(when in BTC) and the transactions card are not done.

image

@notTanveer

Copy link
Copy Markdown
Contributor

we're not using the variable font style anywhere. drop this commit 6122c32

Comment thread components/icons/PayArrowIcon.tsx Outdated
Comment thread components/themes.ts Outdated
Comment thread App.tsx Outdated
</TouchableOpacity>

<View style={styles.actionRow}>
<TouchableOpacity

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessibility regression. These inline action buttons dropped the accessibilityRole/accessibilityLabel that the old FButton set automatically:

  • The icon-only Scan button (just below) has no <Text> child, so VoiceOver/TalkBack announces it with no name at all.
  • Request and Pay still read their text but lost the explicit button role.
  • The disabled Pay state (zero balance) has no accessibility cue. Note accessibilityState={{ disabled: true }} would be wrong here since the button still fires the toast — use an accessibilityHint like "No balance yet" instead.

Please add accessibilityRole="button" to the three action buttons (and to the toast Request / "Share your address" buttons), and accessibilityLabel="Scan QR code" on the icon-only scan button.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread screen/wallets/WalletsList.tsx Outdated
Comment thread screen/wallets/WalletsList.tsx Outdated
Comment thread screen/wallets/WalletsList.tsx Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClashGrotesk-Variable.ttf is registered here (and in android/link-assets-manifest.json, both Info.plists, the Xcode project, plus the assets/fonts and android/.../assets/fonts copies — ~108KB × 2 platforms), but nothing references it: constants/fonts.ts only maps the static -Regular/-Medium/-Semibold/-Bold .otf weights, and there's no fontFamily: 'ClashGrotesk-Variable' anywhere in the app.

Either wire it up or drop it from all the manifests/plists/assets so we're not shipping dead bytes. What was the intent behind adding it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new icon replaces the old components/ScanIcon.tsx, which now has no remaining references in the codebase (its only consumer was the import removed from WalletsList.tsx). Please delete components/ScanIcon.tsx to avoid leaving dead code behind.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@theanmolsharma

Copy link
Copy Markdown
Collaborator

Why is the scan progress bar not showing up?

Copilot AI review requested due to automatic review settings June 24, 2026 13:03
@chaitika chaitika force-pushed the homescreen-ui-revamp branch from da5089b to 51e60c6 Compare June 24, 2026 13:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@chaitika chaitika force-pushed the homescreen-ui-revamp branch from 51e60c6 to fe698a4 Compare June 24, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants