Send Screen Redesign#115
Open
notTanveer wants to merge 9 commits into
Open
Conversation
notTanveer
force-pushed
the
feat/send-redesign
branch
2 times, most recently
from
d03ffbf to
3030a4d
Compare
chaitika
reviewed
Jun 10, 2026
Contributor
|
i can see verbose comments at multiple places. would suggest to keep them only if explicitly needed, and avoid over-explanation |
Contributor
|
the
|
Contributor
|
is the allowed unit to enter amount only btc, or should it be both btc <-> sats ? on |
Contributor
Author
as per the new design, we can only change the unit from the settings. please post this in figma, lets see what matt and anmol has to say |
theanmolsharma
requested changes
Jun 11, 2026
notTanveer
added a commit
to notTanveer/silent-pay-wallet
that referenced
this pull request
Jun 11, 2026
- Remove dead HeaderRightButton memo in Confirm; simplify setOptions effect to [setOptions] dep only - Drop redundant String() wrap on satoshiToBTC() in Confirm - Collapse unreachable addresses.length > 1 branch in SendDetails; remove details_recipient_title loc key - Fix editable AmountHero when Max active: pass '' so editing starts from a blank field - Make ScanQRIcon color prop required (drop hardcoded '#754CE8' default) - Fix themes.ts comment: dark mode is not wired up, not "inherits via spread"
notTanveer
force-pushed
the
feat/send-redesign
branch
2 times, most recently
from
b7b86f3 to
5e9f5c8
Compare
theanmolsharma
requested changes
Jun 15, 2026
notTanveer
force-pushed
the
feat/send-redesign
branch
from
80969f9 to
7072c82
Compare
Collaborator
|
@notTanveer please fix the E2E tests |
isScanActive() was removed from HDSilentPaymentsWallet in bfac4ef while the isScannable() runtime guard still required it, so isScannable() returned false for every wallet. That silently broke two things: - deleteWallet skipped wallet.cancelScan() (gated behind the guard), so a deleted wallet's scan loop + polling kept running and a re-import started a second concurrent scan. - useScannableWallet returned null and the scan-state callback was never wired, so the WalletList progress bar never rendered. Since the app is single-wallet-type (TWallet = HDSilentPaymentsWallet, and deserialization rejects all other types), drop the IScannableWallet interface and isScannable() guard entirely and call the scan methods directly on the concrete wallet. This makes every scan call site compile-checked, so removing one of these methods now fails tsc instead of failing silently at runtime. Add a unit test asserting the wallet still exposes the scan-control surface.
notTanveer
force-pushed
the
feat/send-redesign
branch
from
7072c82 to
d0646be
Compare
notTanveer
force-pushed
the
feat/send-redesign
branch
from
a95182f to
1e9a997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revamp Send Screen