Interface and Abstract Class Nesting #386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermost containing type when that type is nested inside other types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands upon #333 and allows for nesting inside
abstract partial classandpartial interface.Added tests for each type of nesting allowed.
This additionally fixes an issue with the current implementation where the XML remarks are added to the containing type instead of the MemoryPack type itself.
The only part about this that I feel unhappy with is the added Action in the
Emit(StringBuilder writer, IGeneratorContext context, Action appendTypeRemarks)method. The reason I did this was I needed to capture multiple variables in another scope with theAppendTypeRemarks(string? serializationInfoLogDirectoryPath, TypeMeta typeMeta, StringBuilder sb, string fullType)method as the remarks need to be applied to different locations based upon usage of either thetypeMeta.EmitUnionFormatterTemplateor thetypeMeta.EmitIf you have a better idea, I am happy to re-work it to be cleaner.