Add thread info to json and message pack #210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubickanov
force-pushed
the
rubickanov/thread-info
branch
from
e40e03a to
76d7531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
はじめまして。どうぞよろしくお願いいたします。
I'd like to add support for including thread information in both JSON and MessagePack logs — specifically ThreadId, ThreadName, and IsThreadPoolThread.
Also, I noticed that MemberName, FilePath, and LineNumber were missing from the MessagePack format, so I added those as well.
Let me know if anything needs to be changed. Thanks for the great logger!