Skip to content

Conversation

Meow404
Copy link
Collaborator

@Meow404 Meow404 commented Jun 26, 2025

Fixes #12


This change is Reviewable

@Meow404 Meow404 self-assigned this Jun 26, 2025
@Meow404 Meow404 force-pushed the stephen/update-drake-version branch from 8d80b7f to 60326f3 Compare June 26, 2025 19:09
@Meow404 Meow404 requested a review from xuanhien070594 June 26, 2025 19:11
@Meow404 Meow404 marked this pull request as ready for review June 27, 2025 14:21
@xuanhien070594
Copy link
Contributor

WORKSPACE line 1 at r1 (raw file):

# This file marks the root of the Bazel workspace.

Can we delete this file?

Copy link
Collaborator Author

@Meow404 Meow404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @xuanhien070594)


WORKSPACE line 1 at r1 (raw file):

Previously, xuanhien070594 (Hien Bui) wrote…

Can we delete this file?

Done.

@xuanhien070594
Copy link
Contributor

MODULE.bazel line 48 at r1 (raw file):

# You can also use DRAKE_COMMIT to choose a Drake release; e.g.:
DRAKE_COMMIT = "v1.42.0"

Is there any conflicts if dairlib main is currently using Drake 1.39?

Copy link
Contributor

@xuanhien070594 xuanhien070594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Just one minor comment.

Reviewed 10 of 10 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @Meow404)

Copy link
Collaborator Author

@Meow404 Meow404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @xuanhien070594)


MODULE.bazel line 48 at r1 (raw file):

Previously, xuanhien070594 (Hien Bui) wrote…

Is there any conflicts if dairlib main is currently using Drake 1.39?

Hard to say for certain. My local testing seem to imply there shouldn't be an issue. However, will know for certain whilst working on #10

@Meow404 Meow404 merged commit 88dc2c1 into main Jun 30, 2025
1 check was pending
@Meow404 Meow404 deleted the stephen/update-drake-version branch July 17, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump Drake version to latest

2 participants