[ENG-284] Port the `price` crate to the `ts-sdk` by xbtmatt · Pull Request #100 · DASMAC-com/dropset-alpha

xbtmatt · 2026-04-03T19:01:07Z

Summary

Ports the price Rust crate to the TypeScript SDK with unit tests and a few misc extra helper functions for the frontend to use.

Also updates the frontend/tsconfig.json and the ts-sdk/tsconfig.json to work together properly by aliasing the ts-sdk paths to @/ts-sdk/* rather than @/* (which conflicts with the frontend doing the same thing).

Changes

Add price module to ts-sdk. This ports the Rust price crate (encoding, decoding, mantissa validation, order info, client helpers) to TypeScript using decimal.js
Add quoteFromBase / baseFromQuote conversion utilities with bigint and Decimal overloads
Add liquidity utilities (marketLiquidity, totalLiquidity) for aggregating quote-denominated liquidity across order books
Add DropsetMarketAccount and DropsetMarketView types
Rename getDropsetMarkets to fetchDropsetMarketAccounts and add fetchDropsetMarketViews helper
Unify tsconfig path aliases to @/ts-sdk/* across ts-sdk and frontend
Add decimal.js dependency (cataloged in pnpm-workspace.yaml)
Add unit tests for price module (encoding, decoding, mantissa validation, client helpers, utils) and liquidity utils

linear · 2026-04-03T19:01:10Z

ENG-284

Copilot

Pull request overview

Ports the Rust price crate into the TypeScript SDK (ts-sdk) and aligns TS path aliases so the frontend and SDK can coexist without @/* collisions.

Changes:

Added a new ts-sdk/src/price/* module (encoding/decoding, conversions, client helpers) with Jest unit tests.
Added liquidity helper utilities (marketLiquidity, totalLiquidity) plus unit tests.
Updated TS path aliases in ts-sdk and frontend so SDK imports use @/ts-sdk/*.

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
ts-sdk/tsconfig.json	Switch SDK path alias to `@/ts-sdk/*` to avoid frontend conflict.
frontend/tsconfig.json	Adds `@/ts-sdk` and `@/ts-sdk/*` aliases into the frontend.
ts-sdk/src/price/*	New TS port of the Rust price crate (encoding/decoding/helpers).
ts-sdk/src/utils/liquidity.ts	New liquidity aggregation helpers built on the price utilities.
ts-sdk/src/utils/index.ts	New `fetchDropsetMarketAccounts/views` helpers; re-exports liquidity helpers.
ts-sdk/src/types/index.ts	Adds `DropsetMarketAccount` / `DropsetMarketView` convenience types.
ts-sdk/src/tests/unit/**	Adds unit tests for price + liquidity; updates imports for new alias.
ts-sdk/src/tests/e2e/dropset-accounts.test.ts	Updates e2e tests to use the new fetch helpers and aliases.
ts-sdk/src/dropset-interface/market-view-all.ts, ts-sdk/src/const.ts	Updates internal imports to the new `@/ts-sdk/*` alias.
ts-sdk/package.json, pnpm-workspace.yaml	Adds `decimal.js` and catalogs it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ts-sdk/src/price/validated-mantissa.ts

ts-sdk/src/price/client-helpers.ts

ts-sdk/src/price/encoded-price.ts

ts-sdk/src/price/lib.ts

ts-sdk/src/price/utils.ts

ts-sdk/src/utils/index.ts

…price` lib functions

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ts-sdk/src/price/encoded-price.ts

ts-sdk/src/price/lib.ts

ts-sdk/src/rust-types/u64.ts

ts-sdk/src/price/lib.ts

ts-sdk/src/price/client-helpers.ts

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ts-sdk/src/price/encoded-price.ts

ts-sdk/src/price/lib.ts

ts-sdk/src/rust-types/u64.ts

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ts-sdk/src/price/client-helpers.ts

ts-sdk/src/price/lib.ts

ts-sdk/src/tests/unit/price/client-helpers.test.ts

ts-sdk/src/price/lib.ts

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ts-sdk/src/utils/liquidity.ts

ts-sdk/src/price/validated-mantissa.ts

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-04T01:00:18Z

ts-sdk/src/price/decoded-price.ts

+import { Decimal } from "decimal.js";
+import { ensureU8, ensureU32, type U8 } from "../rust-types";
+import { decimalPow10 } from "./client-helpers";
+import { ENCODED_PRICE_INFINITY, ENCODED_PRICE_ZERO } from "./encoded-price";
+import { PriceError } from "./error";
+import { BIAS, PRICE_MANTISSA_BITS, PRICE_MANTISSA_MASK } from "./lib";


There is a circular module dependency between decoded-price.ts and client-helpers.ts (decoded-price imports decimalPow10 from client-helpers, while client-helpers imports decodePrice/decodedPriceToDecimal from decoded-price). With Jest/ts-jest (CommonJS) this pattern can lead to partially-initialized exports at runtime (e.g. decodePrice being undefined inside client-helpers), depending on evaluation order. Consider breaking the cycle by moving decimalPow10 into a small standalone module (e.g. pow10.ts) or by inlining the power-of-10 logic in decodedPriceToDecimal.

Add price utilities to the ts-sdk

5e8fb4a

Copilot AI review requested due to automatic review settings April 3, 2026 19:01

Copilot started reviewing on behalf of xbtmatt April 3, 2026 19:01 View session

Organize pnpm-workspace.yaml

302f9a6

Copilot AI reviewed Apr 3, 2026

View reviewed changes

xbtmatt mentioned this pull request Apr 3, 2026

[ENG-274] Add landing page, market pages, and header toolbar to frontend #99

Draft

4 tasks

xbtmatt added 3 commits April 3, 2026 13:00

Add unsigned integer branded types and tests, use them as inputs to `…

85d62cf

…price` lib functions

Split out lint command to have ts and ts:fix variants

ccd6b4d

Use on the fly precise decimal

9039dce

Copilot AI review requested due to automatic review settings April 3, 2026 20:11

Copilot started reviewing on behalf of xbtmatt April 3, 2026 20:12 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

xbtmatt added 2 commits April 3, 2026 13:29

Avoid downcasts by using bigint as intermediate type, avoid float errors

bf9a12b

Add check for silent truncation on biased exponent conversion

63ae612

Copilot AI review requested due to automatic review settings April 3, 2026 20:34

Copilot started reviewing on behalf of xbtmatt April 3, 2026 20:34 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

ts-sdk/src/price/encoded-price.ts Outdated Show resolved Hide resolved

ts-sdk/src/price/lib.ts Show resolved Hide resolved

ts-sdk/src/rust-types/u64.ts Show resolved Hide resolved

Copilot AI review requested due to automatic review settings April 3, 2026 21:42

xbtmatt added 3 commits April 3, 2026 14:42

Fix checks and use Number.isSafeInteger, check rebiased overflow

fcc1845

Use checked U64 arithmetic in to_order_info port

eff74a6

Format

bb2d58a

xbtmatt force-pushed the ENG-284 branch from 62dfdc6 to bb2d58a Compare April 3, 2026 21:42

Copilot started reviewing on behalf of xbtmatt April 3, 2026 21:42 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

Don't use hardcoded magic numbers, use PRICE_EXPONENT_MAX

21229a6

xbtmatt requested a review from Copilot April 3, 2026 22:41

Copilot started reviewing on behalf of xbtmatt April 3, 2026 22:41 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

xbtmatt requested a review from Copilot April 3, 2026 22:47

xbtmatt requested a review from alnoki April 3, 2026 22:47

Copilot started reviewing on behalf of xbtmatt April 3, 2026 22:47 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

ts-sdk/src/utils/liquidity.ts Show resolved Hide resolved

ts-sdk/src/price/validated-mantissa.ts Outdated Show resolved Hide resolved

Early return with better error msg in validated price mantissa check

462425b

xbtmatt requested a review from Copilot April 4, 2026 00:55

Copilot started reviewing on behalf of xbtmatt April 4, 2026 00:55 View session

Copilot AI reviewed Apr 4, 2026

View reviewed changes

Conversation

xbtmatt commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Uh oh!

linear bot commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

xbtmatt commented Apr 3, 2026 •

edited

Loading