Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
register.s, verifying ownership of the respective mintsand that each program is Token Program or Token 2022
the duplicate position is
BaseTokenProgramand cross-checksmint owners match
#[instruction_accounts]proc macro to emit per-variant_POSposition constants (e.g.REGISTER_MARKET_ACCOUNTS_BASE_TOKEN_PROGRAM_POS)with auto-generated assembly comments from variant names
inputandinput_shiftedfields toRegisterMarketFramefor stack-based pointer persistence across syscalls, replacing
the
Store(input)register-only patternpubkey_offsets!constants forBASE_OWNERandQUOTE_OWNERenabling direct per-chunk memory access without intermediate
pointer registers
pinocchio-tokenandpinocchio-token-2022as workspacedependencies, re-exporting
TOKEN_PROGRAM_IDandTOKEN_2022_PROGRAM_IDfrom the interfacepubkey!constant form (renamed fromaddress!) forsplitting known pubkeys into chunk/lo/hi assembly constants
CHUNK_{0..3}_OFFfromsize_of::<u64>()instead ofhardcoded values
BaseTokenProgramIsDuplicate,BaseTokenProgramNotBaseMintOwner,BaseTokenProgramNotTokenProgram,InvalidQuoteTokenProgramDuplicate,DupQuoteTokenProgramNotQuoteMintOwner,NonDupQuoteTokenProgramNotQuoteMintOwner,QuoteTokenProgramNotTokenProgrampubkey comparisons and dynamic column-width formatting in
test output
validation flow, frame store/retrieve operations, and
rent-to-base-token-program advance before CPI
Algorithm.vueandwiden
.ps-linenumfor triple-digit line numbers#[instruction_accounts]docs in build-scaffoldingand rename
make docs-devtomake docsin CLAUDE.mdblake3 <1.8.4toavoid
digest0.10/0.11 conflict(blueshift-gg/sbpf#109)
clippy::erasing_opandclippy::identity_opinmacro-generated immediate constants