An assortment of CMake fixes and cleanups #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilers like Clang are becoming available on Windows. If there's a requirement on something provided by only MINGW and MSVC, it should be specified directly.
- The CLSOCKET_SHARED logic is done for free by the standard CMake option BUILD_SHARED_LIBS. - The CLSOCKET_DEP_ONLY logic can be achieved by passing the EXCLUDE_FROM_ALL option to add_subdirectory when adding clsocket.
Global names beginning with an underscore are reserved, and each system already defines relevant macros: - All Linux and BSD targets (except Apple) define __unix__ - All Apple targets define __APPLE__ - All Windows targets define _WIN32 For more information, see http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system
Makes it easier to use inside of another project by correctly propagating usage requirements.
It's set automatically based on file extension.
It was inconsistent, standardize on the KitWare preferred style.
|
I think the CI failure is fixed by #11, and isn't related to these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.