Skip to content

Conversation

@mzuenni
Copy link
Contributor

@mzuenni mzuenni commented Nov 2, 2025

The 2025-09 spec defines what a floating point is. This PR changes the default_compare.cc accordingly.

@meisterT
Copy link
Member

meisterT commented Nov 3, 2025

@mzuenni I have just created some basic tests in #3183 - I think it makes sense to merge that one first and then add more tests that do not pass today but pass after your changes.

Also consider splitting up the formatting-only changes into a separate commit

@mzuenni
Copy link
Contributor Author

mzuenni commented Nov 3, 2025

@meisterT sounds good. Some inspiration for tests: https://github.com/RagnarGrootKoerkamp/BAPCtools/blob/main/test/default_output_validator/default_output_validator.yaml (with these changes all those tests should be passed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants