Skip to content

Conversation

@cubercsl
Copy link
Contributor

@cubercsl cubercsl commented Nov 2, 2025

Fix the disk backlog during scoreboard pictures rendering.

When running a contest with 500+ teams, this implementation consumes a large amount of CPU and causes disk backlog issues. However, it seems some unit test failed after my fix.

In our running contest now, the actual mitigation is to turn off the scoreboard org logo display

cc @moesoha. If he proposes a better implementation in a few days, I will close this PR.

@cubercsl cubercsl marked this pull request as draft November 2, 2025 04:09
@nickygerritsen
Copy link
Member

Maybe it's even better to cache the results of getAssetFiles? We can easily add a class property that stores the result. What do you think? If so, we need to also implement the Symfony\Contracts\Service\ResetInterface and reset it for when it is used inside a long running process.

@moesoha
Copy link
Contributor

moesoha commented Nov 2, 2025

@nickygerritsen Yes, you are correct. I have already drafted a patch with cache earlier this day, and we are going to have it tested before push here.

@nickygerritsen
Copy link
Member

@nickygerritsen Yes, you are correct. I have already drafted a patch with cache earlier this day, and we are going to have it tested before push here.

Great, thanks!

@cubercsl cubercsl changed the title Check file existence instead of asset array Cache the results of getAssetFiles Nov 5, 2025
Fix the disk backlog during scoreboard pictures rendering.

Signed-off-by: cubercsl <[email protected]>

Co-authored-by: Soha Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants