Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to some objects returned as None instead of empty array #78

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

vku-ibm
Copy link
Collaborator

@vku-ibm vku-ibm commented Jan 29, 2025

If any of the reviewers remember if effected part of the test, ever returned populated array of authors, please let me know.

@vku-ibm vku-ibm requested review from vagenas and dolfim-ibm January 29, 2025 13:01
@vku-ibm
Copy link
Collaborator Author

vku-ibm commented Jan 29, 2025

The change to notebook is following:

all_results.append(
{
"Filename": row["_source"]["file-info"]["filename"],
"Title": metadata.get("title", ""),
"Authors": ", ".join(
[author["name"] for author in metadata.get("authors")]) if metadata.get("authors") is not None else ""
,
}
)

@vku-ibm vku-ibm merged commit 1f13c27 into main Jan 29, 2025
1 of 4 checks passed
@vku-ibm vku-ibm deleted the vku/small-fix branch January 29, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants