Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: autorelease #72

Merged
merged 9 commits into from
Sep 10, 2024
Merged

ci: autorelease #72

merged 9 commits into from
Sep 10, 2024

Conversation

dolfim-ibm
Copy link
Contributor

@dolfim-ibm dolfim-ibm commented Sep 9, 2024

On top of #71

Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
@PeterStaar-IBM
Copy link
Contributor

@dolfim-ibm love this! A few comments,

  1. Do we want to use this to move to version 1.x.x? Since you are renaming files, I believe we might be breaking some things in docling
  2. Can we document (?in the README?) how PR's need to be done to bump the correct versions (eg !feat, feat, fix, etc)?

PeterStaar-IBM
PeterStaar-IBM previously approved these changes Sep 10, 2024
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! super work!

Signed-off-by: Michele Dolfi <[email protected]>
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good!

@dolfim-ibm dolfim-ibm merged commit 57e2334 into main Sep 10, 2024
26 checks passed
@dolfim-ibm dolfim-ibm deleted the ci-autorelease branch September 10, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants