Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Define LTR/RTL text direction in HTML export #152

Merged
merged 6 commits into from
Feb 5, 2025
Merged

fix: Define LTR/RTL text direction in HTML export #152

merged 6 commits into from
Feb 5, 2025

Conversation

cau-git
Copy link
Contributor

@cau-git cau-git commented Feb 5, 2025

No description provided.

@cau-git cau-git changed the title feat: Define RTL text direction in HTML export feat: Define LTR/RTL text direction in HTML export Feb 5, 2025
@mergify Mergify
Copy link

mergify bot commented Feb 5, 2025 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

PeterStaar-IBM and others added 3 commits February 5, 2025 12:32
@PeterStaar-IBM @cau-git
proposal for cau/rtl-text
537a6a6 
Signed-off-by: Peter Staar <[email protected]>
@cau-git
fix: Form HTML tags with utility method
4cabfb8 
Signed-off-by: Christoph Auer <[email protected]>
@cau-git
Update tests
4d8eab9 
Signed-off-by: Christoph Auer <[email protected]>
PeterStaar-IBM
PeterStaar-IBM previously approved these changes Feb 5, 2025
View reviewed changes
docling_core/types/doc/document.py Outdated Show resolved Hide resolved
docling_core/types/doc/document.py Outdated Show resolved Hide resolved
docling_core/types/doc/document.py Outdated Show resolved Hide resolved
docling_core/types/doc/document.py Outdated Show resolved Hide resolved
docling_core/types/doc/document.py Outdated Show resolved Hide resolved
docling_core/types/doc/document.py Outdated Show resolved Hide resolved
@cau-git
Remove commented code
11a5eec 
Signed-off-by: Christoph Auer <[email protected]>
@cau-git cau-git changed the title feat: Define LTR/RTL text direction in HTML export fix: Define LTR/RTL text direction in HTML export Feb 5, 2025
dolfim-ibm
dolfim-ibm requested changes Feb 5, 2025
View reviewed changes
docling_core/types/doc/document.py Outdated Show resolved Hide resolved
docling_core/types/doc/document.py Show resolved Hide resolved
@cau-git
Add back escaping
4606a5f 
Signed-off-by: Christoph Auer <[email protected]>
@cau-git cau-git merged commit 3cf31cb into main Feb 5, 2025
8 checks passed
@cau-git cau-git deleted the cau/rtl-text branch February 5, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfim-ibm dolfim-ibm dolfim-ibm approved these changes

@PeterStaar-IBM PeterStaar-IBM Awaiting requested review from PeterStaar-IBM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cau-git @PeterStaar-IBM @dolfim-ibm