fix: Enable MyPy in pre-commit and refactor the code to fix all errors #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: Matteo Omenetti <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
dolfim-ibm
requested changes
Jan 28, 2025
| if (type(temperature) != float and type(temperature) != int) or temperature < 0: | ||
| if ( | ||
| temperature is None | ||
| or (type(temperature) != float and type(temperature) != int) |
There was a problem hiding this comment.
better use isinstance() here
…ce()` instead of `type()` Signed-off-by: Nikos Livathinos <[email protected]>
dolfim-ibm
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the MyPy static typing checks, adds MyPy in
pre-commitconfiguration and does the necessary code refactoring to fix all identified errors.Checklist: