Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename distribution pkg & import pkg #2

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

vagenas
Copy link
Contributor

@vagenas vagenas commented Jan 8, 2025

Rationale: aligning with the convention used in the langchain world, where pkgs are called langchain-X
See https://github.com/langchain-ai/langchain/blob/b1dafaef9b2c32151acb42367012e0a7d35067e3/libs/packages.yml

The repo itself though can remain as docling-langchain I think, as users do not really need to care about that name.

@vagenas vagenas requested a review from dolfim-ibm January 8, 2025 09:57
Copy link

mergify bot commented Jan 8, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@vagenas vagenas requested a review from cau-git January 8, 2025 10:44
@vagenas vagenas merged commit bc98187 into main Jan 8, 2025
7 checks passed
@vagenas vagenas deleted the rename-package branch January 8, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants