Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: robustify parser_v2 and add sanitize_cells to the library API #57

Merged
merged 40 commits into from
Dec 7, 2024
Merged

feat!: robustify parser_v2 and add sanitize_cells to the library API #57

merged 40 commits into from
Dec 7, 2024

Conversation

PeterStaar-IBM
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM commented Nov 13, 2024 •
edited
Loading

@PeterStaar-IBM PeterStaar-IBM mentioned this pull request Nov 16, 2024
Closed
@PeterStaar-IBM
merged with main
9729745 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
merged with main (2)
372385e 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
added the S3 processing script
49ff147 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
working on fixing the missing fonts
0aff345 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
made the v2 parser a lot more robust
4aa4739 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
found another bug
5986eeb 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
refactored into annots
56474cb 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM PeterStaar-IBM mentioned this pull request Nov 29, 2024
Open
@PeterStaar-IBM PeterStaar-IBM changed the title feat: adding sanitize_cells to the parser_v2 library API feat: robustify parser_v2 and add sanitize_cells to the library API Nov 29, 2024
@PeterStaar-IBM PeterStaar-IBM mentioned this pull request Nov 29, 2024
Closed
@PeterStaar-IBM PeterStaar-IBM mentioned this pull request Nov 29, 2024
Closed
@PeterStaar-IBM PeterStaar-IBM marked this pull request as ready for review November 30, 2024 05:01
@cau-git
Copy link
Contributor

cau-git commented Dec 3, 2024

@PeterStaar-IBM Let's push this out and continue on another PR for the ligatures. It is a massive improvement already as is.

@cau-git cau-git changed the title feat: robustify parser_v2 and add sanitize_cells to the library API feat!: robustify parser_v2 and add sanitize_cells to the library API Dec 4, 2024
@cau-git cau-git changed the base branch from main to release_v3 December 4, 2024 13:25
cau-git and others added 13 commits December 4, 2024 14:27
@cau-git
Merge branch 'release_v3' of github.com:DS4SD/docling-parse into dev/…
7d4c4ab 
…expose-cell-sanitisation-via-python
@cau-git
Rebase to release_v3
8ea65ae 
Signed-off-by: Christoph Auer <[email protected]>
@PeterStaar-IBM
refactored the tests, updated with text output with ligatures and add…
110a970 
…ed the utils with visualisations

Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
resolved merge conflicts
6316d95 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
reformatted the code
c764347 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
fixed the mypy errors
1df1606 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
made the display text work
6999b8d 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
updated the v1 parser with method documentation
97c0497 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
added encode to see what fails
ba6996e 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
reformatted the code
8913884 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
removed spurious utf8 test
cc4bde5 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
refactored the parameter name and added test for sanitize_cells_in_bbox
489bbb1 
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM
added tough cases
7a70db3 
Signed-off-by: Peter Staar <[email protected]>
@hamedf62
Copy link

hamedf62 commented Dec 6, 2024

kindly update about the RTL support release schedule

@PeterStaar-IBM
Copy link
Contributor Author

kindly update about the RTL support release schedule

Yes, it should be taken care of!

cau-git
cau-git approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@cau-git cau-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚢

@PeterStaar-IBM PeterStaar-IBM merged commit 040e6e6 into release_v3 Dec 7, 2024
32 checks passed
@PeterStaar-IBM PeterStaar-IBM deleted the dev/expose-cell-sanitisation-via-python branch December 7, 2024 10:38
@PeterStaar-IBM PeterStaar-IBM mentioned this pull request Dec 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cau-git cau-git cau-git approved these changes

@dolfim-ibm dolfim-ibm Awaiting requested review from dolfim-ibm

@maxmnemonic maxmnemonic Awaiting requested review from maxmnemonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterStaar-IBM @cau-git @hamedf62