-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add content_layer property to items to address body, furniture and other roles #735
Conversation
…Document furniture Signed-off-by: Christoph Auer <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
One proposal to consider would also be: furniture:
children:
- $ref: '#/texts/0'
- $ref: '#/texts/1'
label: unspecified
name: _root_
parent: null
self_ref: '#/furniture'
body:
children:
- $ref: '#/furniture/0'
- $ref: '#/texts/2'
- $ref: '#/texts/3'
- $ref: '#/furniture/1'
label: unspecified
name: _root_
parent: null
self_ref: '#/body' This would require changes in how the |
For reference, this can be related to #667. |
This would not work since there is no such thing as |
Signed-off-by: Christoph Auer <[email protected]>
This is updated to use a new field in |
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Checklist: