-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ocr): expose rec_keys_path
in RapidOcrOptions to support custom dictionaries
#786
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
rec_keys_path
in RapidOcrOptions to support custom dictionariesrec_keys_path
in RapidOcrOptions to support custom dictionaries
Thanks @terwey for your first contribution. Before we can approve and merge this, we require you to rebase your commit with a sign-off. See the the CONTRIBUTING.md guidelines. In practice, these steps should do it.
|
- Added `rec_keys_path` to `RapidOcrOptions` to align with RapidOCR's capability to use custom character dictionaries. - Passed `rec_keys_path` to `RapidOcrModel` initialization, ensuring the recognition model can load the correct dictionary (e.g., for Latin characters). Signed-off-by: Yorick Terweijden <[email protected]>
55c233e
to
d2f9f05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@terwey it looks like you pushed without running the pre-commit hooks which now are failing in tests. Can you please patch your PR? For example running poetry run pre-commit run --all-files |
Adjusted the alignment of the comment for `rec_keys_path` to maintain consistent formatting. No functional changes were made. Signed-off-by: Yorick Terweijden <[email protected]>
rec_keys_path
toRapidOcrOptions
to align with RapidOCR's capability to use custom character dictionaries.rec_keys_path
toRapidOcrModel
initialization, ensuring the recognition model can load the correct dictionary (e.g., for Latin characters).Checklist: