Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose draw_clusters function #803

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

kmyusk
Copy link
Contributor

@kmyusk kmyusk commented Jan 24, 2025

Expose the draw_clusters() function which was a local function of a method. This general functionality is useful for drawing colorized layout clusters e.g. in docling-eval so there is value in exposing it.

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

@kmyusk kmyusk requested a review from cau-git January 24, 2025 14:55
Copy link

mergify bot commented Jan 24, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the correct typings for parameters and return type to draw_clusters

@PeterStaar-IBM PeterStaar-IBM changed the title feat: expose draw_clusters function chore: expose draw_clusters function Jan 24, 2025
Signed-off-by: Yusik Kim <[email protected]>

add type annotations to function signature

Signed-off-by: Yusik Kim <[email protected]>
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PeterStaar-IBM PeterStaar-IBM merged commit e9768ae into DS4SD:main Jan 24, 2025
7 checks passed
@kmyusk kmyusk deleted the refactor_viz branch January 24, 2025 16:45
kmyusk added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants