Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(backend XML): do not delete temp file in notebook #817

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

ceberam
Copy link
Contributor

@ceberam ceberam commented Jan 27, 2025

A small addition for commit 4df08be after remark #788 (comment) from @vagenas

Since TEMP_DIR is anyway defined as temporary directory (i.e. will be removed upon restart), this part can also be dropped for simplicity (and to avoid any accidents with folder deletions..)

@ceberam ceberam added the documentation Improvements or additions to documentation label Jan 27, 2025
@ceberam ceberam requested review from vagenas and dolfim-ibm January 27, 2025 13:35
@ceberam ceberam self-assigned this Jan 27, 2025
Copy link

mergify bot commented Jan 27, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ceberam ceberam merged commit 4d41db3 into main Jan 27, 2025
9 checks passed
@ceberam ceberam deleted the fix/docs-xml-backend-delete branch January 27, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants