Open
Conversation
*Total -- 170.09kb -> 144.58kb (15%) /app/src/main/res/drawable/chirag.jpg -- 43.28kb -> 33.83kb (21.83%) /app/src/main/res/drawable/astro.jpg -- 98.41kb -> 83.94kb (14.7%) /app/src/main/res/mipmap-xxxhdpi/ic_launcher.png -- 10.40kb -> 9.54kb (8.33%) /app/src/main/res/mipmap-xxhdpi/ic_launcher.png -- 7.72kb -> 7.27kb (5.88%) /app/src/main/res/drawable/download.png -- 1.96kb -> 1.85kb (5.29%) /app/src/main/res/mipmap-hdpi/ic_launcher.png -- 3.51kb -> 3.43kb (2.14%) /app/src/main/res/mipmap-xhdpi/ic_launcher.png -- 4.81kb -> 4.71kb (2.07%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
[ImgBot] Optimize images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue: Organization and Documentation of the code #31
Changes
-Added comments in the main activity layout file which describes the code functionalities
-These were the some issues in fragment cv file which i had fixed:
-The RecyclerView, which is used to display a list of items, does not have a layout manager set. This means that the items will not be properly laid out within the RecyclerView.
-The TextView with id textView8 does not have an android:textColor attribute set, so it will use the default color which may not match with the overall design of the app.
-The FloatingActionButton with id create_cv, does not have any onClickListener set, so it will not perform any action when clicked.
-The android:scrollbars attribute on the ConstraintLayout is set to "vertical", but it does not have a layout_height of "match_parent", so it will not provide any functionality.
-The paddingBottom attribute on the ConstraintLayout is set to 20dp, but it does not have a layout_height of "match_parent", so it will not provide any functionality.