Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复超过两层目录出现解析失败的情况 #3

Conversation

monkeyWie
Copy link
Contributor

@monkeyWie
Copy link
Contributor Author

还有点问题,等我再改改。。。

@monkeyWie
Copy link
Contributor Author

可以了

@DSYZayn DSYZayn self-requested a review February 25, 2025 03:08
@DSYZayn DSYZayn self-assigned this Feb 25, 2025
@DSYZayn DSYZayn added this to the First PR milestone Feb 25, 2025
@DSYZayn DSYZayn changed the base branch from main to deep_directory_more_than_two February 25, 2025 03:14
src/index.js Outdated
* @param {string} path
* @returns {Promise<{name: string, files: {name: string, size: number, path: string?; req: {url: string}}[] | undefined}>}
* @param {string} basePath - 基础路径. e.g. tree/main
* @param {string} filepath - 文件路径. e.g. models/unsloth/DeepSeek-R1-GGUF
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件路径 修改为e.g. insightface/models/buffalo_l
原示例models/unsloth/DeepSeek-R1-GGUF不存在,和api/models易引起歧义。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已更新

@DSYZayn
Copy link
Owner

DSYZayn commented Feb 25, 2025

@monkeyWie
辛苦了,多层目录解析是遗留问题,之前的版本由于没找到合适的仓库无法做这方面的调试 😅。
同时感谢您为类型提示做出的进一步完善工作,这将为后来的开发者提供良好的开发体验 😊。
稍后我将进一步测试该特性分支,以便安全地合并到主分支。

@DSYZayn DSYZayn merged commit b7ac70e into DSYZayn:deep_directory_more_than_two Feb 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants