Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make secret & access key optional to enable instance roles #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nitehawk
Copy link

By making the access key id and secrets optional, the AWS SDK is able to take advantage of instance profiles and any access that the instance has. This removes the need to explicitly track key information in the config or environment.

This should also allow the SDK to utilize the local AWS cli credential cache.

@martinfoakes
Copy link
Contributor

This also fixes the issue that occurs if you're trying to setup this plugin to access the keys via env variables for CI purposes (e.g. secretAccessKey: process.env.AWS_KEY). With isRequired() in play, and the keys set up as above, you get a ValidationError: aws.secretAccessKey is a required field error at build time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants