Skip to content

Fix for "MyDSpace status facets display incorrect (named resource) labels after selection" #4271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VictorDuranEscire
Copy link
Contributor

@VictorDuranEscire VictorDuranEscire commented Apr 29, 2025

Hi @tdonohue, I'am @jtimal partner, I like to share this PR with you.

References


Description

From the frontend, as an immediate measure, add translations according to the value generated by the filter applied.
In the backend service we implemented a way to add a label for each filter applied in the search.

Instructions for Reviewers

To reproduce

  1. Log in as the administrator or any other user with a busy workspace
  2. Expand the Status left-hand facet and select Archived

List of changes in this PR:

  1. I added default translations for the status filter to prevent the selected filter from displaying incorrectly.

  2. Added a setting in discovery.cfg to define a label for each selected filter.

  3. Add a setting to identify which filters to add their labels

  4. Add a validation to validate if a filter is within the above settings and generate its label dynamically.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: MyDSpace
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

MyDSpace status facets display incorrect (named resource) labels after selection
2 participants