Fix for "MyDSpace status facets display incorrect (named resource) labels after selection" #4271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tdonohue, I'am @jtimal partner, I like to share this PR with you.
References
Description
From the frontend, as an immediate measure, add translations according to the value generated by the filter applied.
In the backend service we implemented a way to add a label for each filter applied in the search.
Instructions for Reviewers
To reproduce
List of changes in this PR:
I added default translations for the status filter to prevent the selected filter from displaying incorrectly.
Added a setting in discovery.cfg to define a label for each selected filter.
Add a setting to identify which filters to add their labels
Add a validation to validate if a filter is within the above settings and generate its label dynamically.
Checklist
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.